feat(test-forks): enable filling for TangerineWhistle and SpuriousDragon#2992
Merged
SamWilsn merged 2 commits intoJun 16, 2026
Merged
Conversation
Remove `ignore=True` from `TangerineWhistle` and `SpuriousDragon` so they
are included in `get_deployed_forks()` and filled. Both have distinct EVM
rulesets (`TANGERINE`/`SPURIOUS`) and full EELS `t8n` support but were
never filled, leaving `valid_from("TangerineWhistle")` tests starting at
Byzantium.
Update the `valid_until` marker test for the two added deployed forks.
Split `Frontier`->`Shanghai` + `Cancun` into `Frontier`->`Paris` + `Shanghai`->`Cancun` so the two newly filled forks do not overload the `pre-cancun` job. Keeps the same runner count in both the `fill` matrix (`test.yaml`) and the release split (`fork-ranges.yaml`).
danceratopz
added
C-feat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2992 +/- ##
===================================================
- Coverage 90.52% 90.13% -0.40%
===================================================
Files 535 620 +85
Lines 32893 36641 +3748
Branches 3021 3311 +290
===================================================
+ Hits 29778 33026 +3248
- Misses 2596 3019 +423
- Partials 519 596 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
approved these changes
Jun 16, 2026
Contributor
|
cc: #2173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
fillforTangerineWhistleandSpuriousDragonby removingignore=True, so they are included inget_deployed_forks(). Both have distinct EVM rulesets (TANGERINE/SPURIOUS) and full EELSt8nsupport, but were never filled. This restores dormant coverage: e.g.valid_from("TangerineWhistle")EIP-150 gas-cost tests previously started filling at Byzantium.DAOForkand the Glacier forks stay ignored, as they introduce no EVM-level rule changes to cover (DAO is a one-off state move, Glaciers only delay the difficulty bomb).fillmatrix and the releasefork-ranges.yamlsplit to absorb the two extra forks with no added runners:pre-cancun+cancun(Frontier->Shanghai,Cancun) becomepre-shanghai+shanghai-cancun(Frontier->Paris,Shanghai->Cancun). Coverage is identical and the critical path stays bound by the single-forkprague/amsterdamjobs.🔗 Related Issues or PRs
Motivation: #2975 (comment) (
fillis EELS' entire test coverage, so forks that get refactored often, like Tangerine Whistle and Spurious Dragon, must not be disabled).Partially fixes #2173
✅ Checklist
just statictype(scope):.Cute Animal Picture